fix: fix memory leak while downloading large files #1707
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemented generator to keep RAM usage equal to the 'chunksize' over time.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). For more information, open the CLA check for this pull request. |
hexadivine
changed the title
parthea
changed the title
parthea
reviewed
Mar 15, 2022
| """Constructor. | ||
|
|
||
| Args: | ||
| fd: io.Base or file object, The stream in which to write the downloaded |
There was a problem hiding this comment.
To avoid breaking existing users, ideally we should continue support the existing behaviour as well as the new desired behaviour.
|
Hi @h3x4d1v1n3, Thanks for opening a Pull Request! I apologize for the delay in reviewing this PR. Please could you add a test and backwards compatible option? |
parthea
added
kokoro:force-run
yoshi-kokoro
removed
kokoro:run
|
For the backward compatibility I can add another function to the lattest version that will fix this issue. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented generator to keep RAM usage equal to the 'chunksize' over time.
Fixes #1706